[17.0] [MIG] website_crm_privacy_policy #1034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix review comments - Icon changed - Remove website_legal_page depedency - Set Privacy policy link for opening in new tab, in order to not change user focus and avoid losing any data entered by user in contactus form - [IMP] README and OCA as author OCA Transbot updated translations from Transifex
… test fails on this dead link.
New `website_form` addon includes an undocumented validation system. By simply adapting layout to what it wants, we get validation for free.
[UPD] Update website_crm_privacy_policy.pot
[UPD] Update website_crm_privacy_policy.pot [UPD] README.rst
[UPD] Update website_crm_privacy_policy.pot [UPD] README.rst [UPD] README.rst
… does not exist TT42194
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-16.0/website-16.0-website_crm_privacy_policy Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_crm_privacy_policy/
Currently translated at 100.0% (1 of 1 strings) Translation: website-16.0/website-16.0-website_crm_privacy_policy Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_crm_privacy_policy/es/
The legal terms acceptance checkbox container had incompatible classes with the editor that caused a property access error. This prevented the text or link from being edited. This has been fixed to avoid incompatibilities with the editor itself and with other modules such as website_form_require_legal which adds the same functionality of accepting terms for forms. TT45834
Currently translated at 100.0% (1 of 1 strings) Translation: website-16.0/website-16.0-website_crm_privacy_policy Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_crm_privacy_policy/it/
sbiosca-s73
force-pushed
the
17.0-mig-website_crm_privacy_policy
branch
from
db09144
to
5b50ee7
Compare
sbiosca-s73
force-pushed
the
17.0-mig-website_crm_privacy_policy
branch
from
5b50ee7
to
d89596f
Compare
sbiosca-s73
force-pushed
the
17.0-mig-website_crm_privacy_policy
branch
from
d89596f
to
d2280c1
Compare
sbiosca-s73
force-pushed
the
17.0-mig-website_crm_privacy_policy
branch
from
11d8f51
to
3d30de7
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@pedrobaeza please put "no stale" label |
|
Instead, please enroll reviewers. Anyway, this one should be rebased and remove the dependency. /ocabot migration website_crm_privacy_policy |
|
@antespi please review the code |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration website_crm_privacy_policy to 17.0